[PATCH v5 6/7] arm64: dts: renesas: Add R8A78000 X5H DTs
Marc Zyngier
maz at kernel.org
Fri Sep 19 01:33:29 PDT 2025
Hi Geert,
On Fri, 19 Sep 2025 07:52:38 +0100,
Geert Uytterhoeven <geert at linux-m68k.org> wrote:
>
> Hi Marc,
>
> On Thu, 18 Sept 2025 at 12:01, Marc Zyngier <maz at kernel.org> wrote:
> > On Thu, 18 Sep 2025 07:27:26 +0100,
> > Kuninori Morimoto <kuninori.morimoto.gx at renesas.com> wrote:
> > > + /*
> > > + * The ARM GIC-720AE - View 1
> > > + *
> > > + * see
> > > + * r19uh0244ej0052-r-carx5h.pdf
> > > + * - attachments: 002_R-CarX5H_Address_Map_r0p51.xlsx
> > > + * - sheet [RT]
> > > + * - line 619
> > > + */
> > > + gic: interrupt-controller at 39000000 {
> > > + compatible = "arm,gic-v3";
> > > + #interrupt-cells = <3>;
> > > + #address-cells = <0>;
> > > + interrupt-controller;
> > > + reg = <0 0x39000000 0 0x20000>,
> > > + <0 0x39080000 0 0x800000>;
> > > + interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> > > + };
> >
> > I already asked for:
> >
> > - this comment to be dropped, as it serves zero purpose to the common
> > mortal
>
> What about using a different comment instead?
>
> /* Linux must use I/F Region 1 */
>
> I.e. replace "View 1" by the above.
I definitely wouldn't mention Linux, as the DT is not specific to any
particular OS. This is more about what block the main CPUs are allowed
to use. Also, "View" is the term used in the TRM to describe the
multiplexing of multiple GIC "instances" on a single GIC
implementation in a mixed-criticality system, so keeping it makes more
sense.
Something like:
/* Application Processors manage View-1 of a GIC-720AE */
and the mention of the TRM and other spreadsheets dropped.
Thanks,
M.
--
Jazz isn't dead. It just smells funny.
More information about the linux-arm-kernel
mailing list