[PATCH v14 02/10] power: reset: reboot-mode: Add device tree node-based registration

[Sebastian Reichel]

Hi,

On Wed, Sep 17, 2025 at 09:59:44PM +0530, Shivendra Pratap wrote:
> On 9/17/2025 12:18 AM, Sebastian Reichel wrote:
> > On Fri, Aug 15, 2025 at 08:05:07PM +0530, Shivendra Pratap wrote:
> >> The reboot-mode driver does not have a strict requirement for
> >> device-based registration. It primarily uses the device's of_node
> >> to read mode-<cmd> properties and the device pointer for logging.
> >>
> >> Remove the dependency on struct device and introduce support for
> >> Device Tree (DT) node-based registration. This enables drivers
> >> that are not associated with a struct device to leverage the
> >> reboot-mode framework.
> >>
> >> Signed-off-by: Shivendra Pratap <shivendra.pratap at oss.qualcomm.com>
> >> ---
> > 
> > Please use fwnode instead of device_node, so that the same thing
> > can be used with non DT setups, if that becomes necessary. Otherwise
> > LGTM.
> 
> To be more clear on this, have one question: the current unmodified
> design of reboot-mode is dt based:
> 
> struct device_node *np = reboot->dev->of_node;
> and then parses the node using for_each_property_of_node(np, prop).
> 
> We want to refactor reboot-mode to support non-DT setups by adding
> support for fwnode-based approach (struct fwnode_handle *fwnode)?
> 
> Can you please explain a bit? Some more details would be helpful to
> make the change.

It's fine to keep using of_node internally. But the external API
(include/linux/reboot-mode.h) should use fwnode. Just like the
current external API is not DT specific as it just gets a struct
device. This keeps the external API somewhat ready for non-DT users
and avoids having to change all API users again in the future.

Greetings,

-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20250918/c8918457/attachment.sig>