[PATCH v10 07/13] media: rockchip: add driver for mipi csi-2 receiver

[Michael Riesch]

Hi Philipp,

On 8/25/25 12:37, Philipp Zabel wrote:
> On Di, 2025-08-19 at 01:25 +0200, Michael Riesch via B4 Relay wrote:
>> From: Michael Riesch <michael.riesch at collabora.com>
>>
>> The Rockchip RK3568 MIPI CSI-2 Receiver is a CSI-2 bridge with one
>> input port and one output port. It receives the data with the help
>> of an external MIPI PHY (C-PHY or D-PHY) and passes it to the
>> Rockchip RK3568 Video Capture (VICAP) block.
>>
>> Add a V4L2 subdevice driver for this unit.
>>
>> Signed-off-by: Michael Riesch <michael.riesch at wolfvision.net>
>> Signed-off-by: Michael Riesch <michael.riesch at collabora.com>
>> ---
>>  MAINTAINERS                                    |   1 +
>>  drivers/media/platform/rockchip/Kconfig        |   1 +
>>  drivers/media/platform/rockchip/Makefile       |   1 +
>>  drivers/media/platform/rockchip/rkcsi/Kconfig  |  16 +
>>  drivers/media/platform/rockchip/rkcsi/Makefile |   3 +
>>  drivers/media/platform/rockchip/rkcsi/rkcsi.c  | 741 +++++++++++++++++++++++++
>>  6 files changed, 763 insertions(+)
>>
> [...]
>> diff --git a/drivers/media/platform/rockchip/rkcsi/rkcsi.c b/drivers/media/platform/rockchip/rkcsi/rkcsi.c
>> new file mode 100644
>> index 000000000000..5658ffb60769
>> --- /dev/null
>> +++ b/drivers/media/platform/rockchip/rkcsi/rkcsi.c
>> @@ -0,0 +1,741 @@
> [...]
>> +static int rkcsi_probe(struct platform_device *pdev)
>> +{
>> +	struct device *dev = &pdev->dev;
>> +	struct rkcsi_device *csi_dev;
>> +	int ret;
>> +
>> +	csi_dev = devm_kzalloc(dev, sizeof(*csi_dev), GFP_KERNEL);
>> +	if (!csi_dev)
>> +		return -ENOMEM;
>> +	csi_dev->dev = dev;
>> +	dev_set_drvdata(dev, csi_dev);
>> +
>> +	csi_dev->base_addr = devm_platform_ioremap_resource(pdev, 0);
>> +	if (IS_ERR(csi_dev->base_addr))
>> +		return PTR_ERR(csi_dev->base_addr);
>> +
>> +	ret = devm_clk_bulk_get_all(dev, &csi_dev->clks);
>> +	if (ret != RKCSI_CLKS_MAX)
>> +		return dev_err_probe(dev, -ENODEV, "failed to get clocks\n");
>> +	csi_dev->clks_num = ret;
>> +
>> +	csi_dev->phy = devm_phy_get(dev, NULL);
>> +	if (IS_ERR(csi_dev->phy))
>> +		return dev_err_probe(dev, PTR_ERR(csi_dev->phy),
>> +				     "failed to get MIPI CSI PHY\n");
>> +
>> +	csi_dev->reset = devm_reset_control_array_get_exclusive(dev);
> 
> Why array? rockchip,rk3568-mipi-csi bindings specify a single reset.

Hm. Copy-paste issue, I guess. Good catch, thanks for pointing it out.

Best regards,
Michael

> 
> regards
> Philipp