[PATCH v3 15/39] drm/atmel-hlcdc: Switch to drm_atomic_get_new_crtc_state()

[Manikandan.M at microchip.com]

On 09/09/25 4:57 pm, Maxime Ripard wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The atmel-hlcdc atomic_check implementation uses the deprecated
> drm_atomic_get_existing_crtc_state() helper.
> 
> This hook is called as part of the global atomic_check, thus before the
> states are swapped. The existing state thus points to the new state, and
> we can use drm_atomic_get_new_crtc_state() instead.
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Signed-off-by: Maxime Ripard <mripard at kernel.org>

Reviewed-by: Manikandan Muralidharan <manikandan.m at microchip.com>

> ---
> To: Manikandan Muralidharan <manikandan.m at microchip.com>
> To: Dharma Balasubiramani <dharma.b at microchip.com>
> To: Nicolas Ferre <nicolas.ferre at microchip.com>
> To: Alexandre Belloni <alexandre.belloni at bootlin.com>
> To: Claudiu Beznea <claudiu.beznea at tuxon.dev>
> Cc: dri-devel at lists.freedesktop.org
> Cc: linux-arm-kernel at lists.infradead.org
> ---
>   drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> index 4a7ba0918eca19eca3fd8febd1db1b2d3a8a6e14..59be5f64c058e2be398f207ad436f922135a5ad0 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> @@ -712,11 +712,11 @@ static int atmel_hlcdc_plane_atomic_check(struct drm_plane *p,
>          int i;
> 
>          if (!hstate->base.crtc || WARN_ON(!fb))
>                  return 0;
> 
> -       crtc_state = drm_atomic_get_existing_crtc_state(state, s->crtc);
> +       crtc_state = drm_atomic_get_new_crtc_state(state, s->crtc);
>          mode = &crtc_state->adjusted_mode;
> 
>          ret = drm_atomic_helper_check_plane_state(s, crtc_state,
>                                                    (1 << 16) / 2048,
>                                                    INT_MAX, true, true);
> 
> --
> 2.50.1
> 

-- 
Thanks and Regards,
Manikandan M.