[PATCH] pinctrl: Simplify printks with pOF format
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Fri Sep 12 02:35:26 PDT 2025
On 12/09/2025 11:23, Krzysztof Kozlowski wrote:
> Print full device node name with %pOF format, so the code will be a bit
> simpler.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> ---
> drivers/pinctrl/sprd/pinctrl-sprd.c | 9 +++------
> drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c | 7 +++----
> 2 files changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c
> index c4a1d99dfed0..16cf9d15f247 100644
> --- a/drivers/pinctrl/sprd/pinctrl-sprd.c
> +++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
> @@ -258,8 +258,7 @@ static int sprd_dt_node_to_map(struct pinctrl_dev *pctldev,
>
> grp = sprd_pinctrl_find_group_by_name(pctl, np->name);
> if (!grp) {
> - dev_err(pctl->dev, "unable to find group for node %s\n",
> - of_node_full_name(np));
> + dev_err(pctl->dev, "unable to find group for node %pOF\n", np);
> return -EINVAL;
> }
Heh, I misread the docs and see now in the testing that my patch changes
the behavior. of_node_full_name() is just node name. pOF is full path.
This might be desired (more accurate warning in case many nodes share
similar name) or not...
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list