[PATCH net-next] net: stmmac: est: Drop frames causing HLBS error
G Thomas, Rohan
rohan.g.thomas at altera.com
Thu Sep 11 22:00:17 PDT 2025
Hi Russell,
Thanks for reviewing the patch.
On 9/11/2025 6:21 PM, Russell King (Oracle) wrote:
> On Thu, Sep 11, 2025 at 04:38:16PM +0800, Rohan G Thomas via B4 Relay wrote:
>> @@ -109,6 +109,11 @@ static void est_irq_status(struct stmmac_priv *priv, struct net_device *dev,
>>
>> x->mtl_est_hlbs++;
>>
>> + for (i = 0; i < txqcnt; i++) {
>> + if (value & BIT(i))
>> + x->mtl_est_txq_hlbs[i]++;
>> + }
>
> There's no need for the parens around the for loop.
Sure, will fix this in the next version.
>
> I'm afraid I can't provide much more of a review as I don't have the
> documentation for GMAC4 or XGMAC.
Understood, thanks for taking a look regardless.
>
Best Regards,
Rohan
More information about the linux-arm-kernel
mailing list