[PATCH net 1/2] net: stmmac: est: Fix GCL bounds checks
Russell King (Oracle)
linux at armlinux.org.uk
Thu Sep 11 04:24:35 PDT 2025
On Thu, Sep 11, 2025 at 04:22:59PM +0800, Rohan G Thomas via B4 Relay wrote:
> @@ -1012,7 +1012,7 @@ static int tc_taprio_configure(struct stmmac_priv *priv,
> s64 delta_ns = qopt->entries[i].interval;
> u32 gates = qopt->entries[i].gate_mask;
>
> - if (delta_ns > GENMASK(wid, 0))
> + if (delta_ns >= BIT(wid))
While I agree this makes it look better, you don't change the version
below, which makes the code inconsistent. I also don't see anything
wrong with the original comparison.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
More information about the linux-arm-kernel
mailing list