[PATCH v2 6/6] remoteproc: imx_rproc: Clean up after ops introduction

[Peng Fan]

Hi Frank,

> Subject: Re: [PATCH v2 6/6] remoteproc: imx_rproc: Clean up after ops
> introduction
> >
> > -	if (dcfg->ops && dcfg->ops->detect_mode)
> > -		return dcfg->ops->detect_mode(priv->rproc);
> > -
> > -	switch (dcfg->method) {
> 
> Can you remove 'method' in data struct also?

The method is used in other places and other purpose, imx_rproc_detach
imx_rproc_put_scu, imx_rproc_remove, it is also referred 
imx_dsp_rproc.c.

Could we keep it for now?

Thanks,
Peng.

> 
> Frank
> > -	case IMX_RPROC_NONE:
> > +	/*
> > +	 * To i.MX{7,8} ULP, Linux is under control of RTOS, no need
> > +	 * dcfg->ops or dcfg->ops->detect_mode, it is state
> RPROC_DETACHED.
> > +	 */
> > +	if (!dcfg->ops || !dcfg->ops->detect_mode) {
> >  		priv->rproc->state = RPROC_DETACHED;
> >  		return 0;
> > -	default:
> > -		break;
> >  	}
> >
> > -	return 0;
> > +	return dcfg->ops->detect_mode(priv->rproc);
> >  }
> >
> >  static int imx_rproc_clk_enable(struct imx_rproc *priv)
> >
> > --
> > 2.37.1
> >