[Linux-stm32] [PATCH net-next 08/11] net: stmmac: rename stmmac_init_ptp()

Gatien CHEVALLIER gatien.chevallier at foss.st.com
Wed Sep 10 07:42:18 PDT 2025



On 9/9/25 18:48, Russell King (Oracle) wrote:
> In preparation to cleaning up the (re-)initialisation of timestamping,
> rename the existing stmmac_init_ptp() to stmmac_init_timestamping()
> which better reflects its functionality.
>

I agree it's mostly about time stamping but if the ptp_clk_freq_config()
ops is implemented, then it's not only about timestamping. Wasn't it
fine as is?

> Signed-off-by: Russell King (Oracle) <rmk+kernel at armlinux.org.uk>
> ---
>   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 716c7e21baf1..7cbac3ac2a9d 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -773,13 +773,13 @@ static int stmmac_init_tstamp_counter(struct stmmac_priv *priv,
>   }
>   
>   /**
> - * stmmac_init_ptp - init PTP
> + * stmmac_init_timestamping - initialise timestamping
>    * @priv: driver private structure
>    * Description: this is to verify if the HW supports the PTPv1 or PTPv2.
>    * This is done by looking at the HW cap. register.
>    * This function also registers the ptp driver.
>    */
> -static int stmmac_init_ptp(struct stmmac_priv *priv)
> +static int stmmac_init_timestamping(struct stmmac_priv *priv)
>   {
>   	bool xmac = priv->plat->has_gmac4 || priv->plat->has_xgmac;
>   	int ret;
> @@ -3502,7 +3502,7 @@ static int stmmac_hw_setup(struct net_device *dev, bool ptp_register)
>   				    ERR_PTR(ret));
>   	}
>   
> -	if (stmmac_init_ptp(priv) == 0 && ptp_register)
> +	if (stmmac_init_timestamping(priv) == 0 && ptp_register)
>   		stmmac_ptp_register(priv);
>   
>   	if (priv->use_riwt) {



More information about the linux-arm-kernel mailing list