[PATCH rfcv2 4/8] iommu/arm-smmu-v3: Introduce a per-domain arm_smmu_invs array
kernel test robot
lkp at intel.com
Tue Sep 9 06:01:08 PDT 2025
Hi Nicolin,
kernel test robot noticed the following build errors:
[auto build test ERROR on soc/for-next]
[also build test ERROR on linus/master v6.17-rc5 next-20250909]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Nicolin-Chen/iommu-arm-smmu-v3-Clear-cmds-num-after-arm_smmu_cmdq_batch_submit/20250909-073052
base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
patch link: https://lore.kernel.org/r/80310b98efa4bd7e95d7b3ca302f40d4d69e59c5.1757373449.git.nicolinc%40nvidia.com
patch subject: [PATCH rfcv2 4/8] iommu/arm-smmu-v3: Introduce a per-domain arm_smmu_invs array
config: arm64-randconfig-003-20250909 (https://download.01.org/0day-ci/archive/20250909/202509092020.mxUyqGcN-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250909/202509092020.mxUyqGcN-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509092020.mxUyqGcN-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:1082:23: error: static declaration of 'arm_smmu_invs_merge' follows non-static declaration
1082 | struct arm_smmu_invs *arm_smmu_invs_merge(struct arm_smmu_invs *invs,
| ^~~~~~~~~~~~~~~~~~~
In file included from drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:34:
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h:721:23: note: previous declaration of 'arm_smmu_invs_merge' with type 'struct arm_smmu_invs *(struct arm_smmu_invs *, struct arm_smmu_invs *)'
721 | struct arm_smmu_invs *arm_smmu_invs_merge(struct arm_smmu_invs *invs,
| ^~~~~~~~~~~~~~~~~~~
>> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:1165:8: error: static declaration of 'arm_smmu_invs_unref' follows non-static declaration
1165 | size_t arm_smmu_invs_unref(struct arm_smmu_invs *invs,
| ^~~~~~~~~~~~~~~~~~~
In file included from drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:34:
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h:723:8: note: previous declaration of 'arm_smmu_invs_unref' with type 'size_t(struct arm_smmu_invs *, struct arm_smmu_invs *)' {aka 'long unsigned int(struct arm_smmu_invs *, struct arm_smmu_invs *)'}
723 | size_t arm_smmu_invs_unref(struct arm_smmu_invs *invs,
| ^~~~~~~~~~~~~~~~~~~
>> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:1215:23: error: static declaration of 'arm_smmu_invs_purge' follows non-static declaration
1215 | struct arm_smmu_invs *arm_smmu_invs_purge(struct arm_smmu_invs *invs,
| ^~~~~~~~~~~~~~~~~~~
In file included from drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:34:
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h:725:23: note: previous declaration of 'arm_smmu_invs_purge' with type 'struct arm_smmu_invs *(struct arm_smmu_invs *, size_t)' {aka 'struct arm_smmu_invs *(struct arm_smmu_invs *, long unsigned int)'}
725 | struct arm_smmu_invs *arm_smmu_invs_purge(struct arm_smmu_invs *invs,
| ^~~~~~~~~~~~~~~~~~~
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:1215:23: warning: 'arm_smmu_invs_purge' defined but not used [-Wunused-function]
1215 | struct arm_smmu_invs *arm_smmu_invs_purge(struct arm_smmu_invs *invs,
| ^~~~~~~~~~~~~~~~~~~
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:1165:8: warning: 'arm_smmu_invs_unref' defined but not used [-Wunused-function]
1165 | size_t arm_smmu_invs_unref(struct arm_smmu_invs *invs,
| ^~~~~~~~~~~~~~~~~~~
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:1082:23: warning: 'arm_smmu_invs_merge' defined but not used [-Wunused-function]
1082 | struct arm_smmu_invs *arm_smmu_invs_merge(struct arm_smmu_invs *invs,
| ^~~~~~~~~~~~~~~~~~~
vim +/arm_smmu_invs_merge +1082 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
1063
1064 /**
1065 * arm_smmu_invs_merge() - Merge @to_merge into @invs and generate a new array
1066 * @invs: the base invalidation array
1067 * @to_merge: an array of invlidations to merge
1068 *
1069 * Return: a newly allocated array on success, or ERR_PTR
1070 *
1071 * This function must be locked and serialized with arm_smmu_invs_unref() and
1072 * arm_smmu_invs_purge(), but do not lockdep on any lock for KUNIT test.
1073 *
1074 * Either @invs or @to_merge must be sorted itself. This ensures the returned
1075 * array will be sorted as well.
1076 *
1077 * Caller is resposible for freeing the @invs and the returned new one.
1078 *
1079 * Entries marked as trash will be purged in the returned array.
1080 */
1081 VISIBLE_IF_KUNIT
> 1082 struct arm_smmu_invs *arm_smmu_invs_merge(struct arm_smmu_invs *invs,
1083 struct arm_smmu_invs *to_merge)
1084 {
1085 struct arm_smmu_invs *new_invs;
1086 struct arm_smmu_inv *new;
1087 size_t num_adds = 0;
1088 size_t num_dels = 0;
1089 size_t i, j;
1090
1091 for (i = j = 0; i != invs->num_invs || j != to_merge->num_invs;) {
1092 int cmp = arm_smmu_invs_merge_cmp(invs, i, to_merge, j);
1093
1094 if (cmp < 0) {
1095 /* no found in to_merge, leave alone but delete trash */
1096 if (!refcount_read(&invs->inv[i].users))
1097 num_dels++;
1098 i++;
1099 } else if (cmp == 0) {
1100 /* same item */
1101 i++;
1102 j++;
1103 } else {
1104 /* unique to to_merge */
1105 num_adds++;
1106 j++;
1107 }
1108 }
1109
1110 new_invs = arm_smmu_invs_alloc(invs->num_invs - num_dels + num_adds);
1111 if (IS_ERR(new_invs))
1112 return new_invs;
1113
1114 new = new_invs->inv;
1115 for (i = j = 0; i != invs->num_invs || j != to_merge->num_invs;) {
1116 int cmp = arm_smmu_invs_merge_cmp(invs, i, to_merge, j);
1117
1118 if (cmp <= 0 && !refcount_read(&invs->inv[i].users)) {
1119 i++;
1120 continue;
1121 }
1122
1123 if (cmp < 0) {
1124 *new = invs->inv[i];
1125 i++;
1126 } else if (cmp == 0) {
1127 *new = invs->inv[i];
1128 refcount_inc(&new->users);
1129 i++;
1130 j++;
1131 } else {
1132 *new = to_merge->inv[j];
1133 refcount_set(&new->users, 1);
1134 j++;
1135 }
1136 new++;
1137 }
1138
1139 WARN_ON(new != new_invs->inv + new_invs->num_invs);
1140
1141 return new_invs;
1142 }
1143 EXPORT_SYMBOL_IF_KUNIT(arm_smmu_invs_merge);
1144
1145 /**
1146 * arm_smmu_invs_unref() - Find in @invs for all entries in @to_unref, decrease
1147 * the user counts without deletions
1148 * @invs: the base invalidation array
1149 * @to_unref: an array of invlidations to decrease their user counts
1150 *
1151 * Return: the number of trash entries in the array, for arm_smmu_invs_purge()
1152 *
1153 * This function will not fail. Any entry with users=0 will be marked as trash.
1154 * All trash entries will remain in the @invs until being completely deleted by
1155 * the next arm_smmu_invs_merge() or an arm_smmu_invs_purge() function call.
1156 *
1157 * This function must be locked and serialized with arm_smmu_invs_merge() and
1158 * arm_smmu_invs_purge(), but do not lockdep on any lock for KUNIT test.
1159 *
1160 * Note that the @invs->num_invs will not be updated, even if the actual number
1161 * of invalidations are decreased. Readers should take the read lock to iterate
1162 * each entry and check its users counter until @inv->num_invs.
1163 */
1164 VISIBLE_IF_KUNIT
> 1165 size_t arm_smmu_invs_unref(struct arm_smmu_invs *invs,
1166 struct arm_smmu_invs *to_unref)
1167 {
1168 size_t num_dels = 0;
1169 size_t i, j;
1170
1171 for (i = j = 0; i != invs->num_invs || j != to_unref->num_invs;) {
1172 int cmp;
1173
1174 if (!refcount_read(&invs->inv[i].users)) {
1175 num_dels++;
1176 i++;
1177 continue;
1178 }
1179
1180 cmp = arm_smmu_invs_merge_cmp(invs, i, to_unref, j);
1181 if (cmp < 0) {
1182 /* not found in to_unref, leave alone */
1183 i++;
1184 } else if (cmp == 0) {
1185 /* same item */
1186 if (refcount_dec_and_test(&invs->inv[i].users))
1187 num_dels++;
1188 i++;
1189 j++;
1190 } else {
1191 /* item in to_unref is not in invs or already a trash */
1192 WARN_ON(true);
1193 j++;
1194 }
1195 }
1196 return num_dels;
1197 }
1198 EXPORT_SYMBOL_IF_KUNIT(arm_smmu_invs_unref);
1199
1200 /**
1201 * arm_smmu_invs_purge() - Purge all the trash entries in the @invs
1202 * @invs: the base invalidation array
1203 * @num_dels: expected number of trash entries, typically the return value from
1204 * a prior arm_smmu_invs_unref() call
1205 *
1206 * Return: a newly allocated array on success removing all the trash entries, or
1207 * NULL on failure
1208 *
1209 * This function must be locked and serialized with arm_smmu_invs_merge() and
1210 * arm_smmu_invs_unref(), but do not lockdep on any lock for KUNIT test.
1211 *
1212 * Caller is resposible for freeing the @invs and the returned new one.
1213 */
1214 VISIBLE_IF_KUNIT
> 1215 struct arm_smmu_invs *arm_smmu_invs_purge(struct arm_smmu_invs *invs,
1216 size_t num_dels)
1217 {
1218 struct arm_smmu_invs *new_invs;
1219 size_t i, j;
1220
1221 if (WARN_ON(invs->num_invs < num_dels))
1222 return NULL;
1223
1224 new_invs = arm_smmu_invs_alloc(invs->num_invs - num_dels);
1225 if (IS_ERR(new_invs))
1226 return NULL;
1227
1228 for (i = j = 0; i != invs->num_invs; i++) {
1229 if (!refcount_read(&invs->inv[i].users))
1230 continue;
1231 new_invs->inv[j] = invs->inv[i];
1232 j++;
1233 }
1234
1235 WARN_ON(j != new_invs->num_invs);
1236 return new_invs;
1237 }
1238 EXPORT_SYMBOL_IF_KUNIT(arm_smmu_invs_purge);
1239
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the linux-arm-kernel
mailing list