[PATCH v2 2/3] clk: conf: Support assigned-clock-sscs
Brian Masney
bmasney at redhat.com
Tue Sep 9 02:39:45 PDT 2025
On Tue, Sep 09, 2025 at 04:50:13PM +0800, Peng Fan wrote:
> Hi Brian,
> On Tue, Sep 02, 2025 at 05:49:17PM -0400, Brian Masney wrote:
> [...]
> >> + if (IS_ERR(clk)) {
> >> + if (PTR_ERR(clk) != -EPROBE_DEFER)
> >> + pr_warn("clk: couldn't get clock %d for %pOF\n",
> >> + index, node);
> >> + return PTR_ERR(clk);
> >
> >This chunk can be replaced with dev_warn_probe(). Sorry I missed that in
> >v1. Otherwise the rest looks good to me. With that fixed:
>
> dev_warn_probe() could not be used here. There is no 'device' pointer
> here.
Ahh ok, gotcha.
> I take __set_clk_parents() as example here, so use pr_warn().
>
> >
> >Reviewed-by: Brian Masney <bmasney at redhat.com>
>
> Could I still keep this tag with keeping pr_warn()?
Yes. Thank you!
Brian
More information about the linux-arm-kernel
mailing list