[PATCH] irqchip/gic-v5: Fix kmemleak L2 IST table entries false positives

Lorenzo Pieralisi lpieralisi at kernel.org
Mon Sep 8 06:26:54 PDT 2025


On Tue, Aug 26, 2025 at 08:34:27PM +0100, Catalin Marinas wrote:
> On Mon, Aug 11, 2025 at 03:50:01PM +0200, Lorenzo Pieralisi wrote:
> > diff --git a/drivers/irqchip/irq-gic-v5-irs.c b/drivers/irqchip/irq-gic-v5-irs.c
> > index ad1435a858a4..e8a576f66366 100644
> > --- a/drivers/irqchip/irq-gic-v5-irs.c
> > +++ b/drivers/irqchip/irq-gic-v5-irs.c
> > @@ -5,6 +5,7 @@
> >  
> >  #define pr_fmt(fmt)	"GICv5 IRS: " fmt
> >  
> > +#include <linux/kmemleak.h>
> >  #include <linux/log2.h>
> >  #include <linux/of.h>
> >  #include <linux/of_address.h>
> > @@ -117,6 +118,7 @@ static int __init gicv5_irs_init_ist_linear(struct gicv5_irs_chip_data *irs_data
> >  		kfree(ist);
> >  		return ret;
> >  	}
> > +	kmemleak_ignore(ist);
> 
> Nit: if you ever respin, please add a short comment on why this is a
> false positive (easier to see it in the code than the git logs).

It was merged as-is (have been away for a couple of weeks) but I can send a
patch adding the comments to clarify the code as a follow-up.

Thanks,
Lorenzo

> >  
> >  	return 0;
> >  }
> > @@ -232,6 +234,7 @@ int gicv5_irs_iste_alloc(const u32 lpi)
> >  		kfree(l2ist);
> >  		return ret;
> >  	}
> > +	kmemleak_ignore(l2ist);
> 
> Same here.
> 
> -- 
> Catalin



More information about the linux-arm-kernel mailing list