It's really hard to review the code when it's just sigle line like this: > .../raspberrypi/vchiq-interface}/vchiq_arm.c | 9 +- It's also a head ache to do a cat -n filename and then copy and paste it into an email message... I thought there was a trick to make the diff show up in the email? regards, dan carpenter