[PATCH v1 6/7] hwmon: sl28cpld: add SMARC-sAM67 support

Guenter Roeck linux at roeck-us.net
Sun Sep 7 08:28:19 PDT 2025


On 8/22/25 06:15, Michael Walle wrote:
> The on-board uC on the SMARC-sAM67 board is compatible with the older
> CPLD implementation on the SMARC-sAL28 board, but has different sensors,
> namely two voltage sensors and one temperature sensor. Add support for it.
> 
> Signed-off-by: Michael Walle <mwalle at kernel.org>
> ---
>   drivers/hwmon/sl28cpld-hwmon.c | 76 ++++++++++++++++++++++++++++++++--

Documentation/hwmon/sl28cpld.rst would have to be updated as well.

...

>   static const struct of_device_id sl28cpld_hwmon_of_match[] = {
> -	{ .compatible = "kontron,sl28cpld-fan" },
> +	{ .compatible = "kontron,sl28cpld-fan", .data = &sl28cpld_hwmon_chip_info },
> +	{ .compatible = "kontron,sa67mcu-hwmon", .data = &sa67mcu_hwmon_chip_info },

Effectively this means that the two chips have completely different functionality.
One reports fan speeds, the other reports voltages and current.
This should be a separate driver.

Guenter




More information about the linux-arm-kernel mailing list