[PATCH v7 3/6] arm64: mm: support large block mapping when rodata=full

Ryan Roberts ryan.roberts at arm.com
Thu Sep 4 04:09:05 PDT 2025


On 03/09/2025 20:15, Catalin Marinas wrote:
> On Fri, Aug 29, 2025 at 12:52:44PM +0100, Ryan Roberts wrote:
>> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
>> index 34e5d78af076..114b88216b0c 100644
>> --- a/arch/arm64/mm/mmu.c
>> +++ b/arch/arm64/mm/mmu.c
>> @@ -481,6 +481,8 @@ void create_kpti_ng_temp_pgd(pgd_t *pgdir, phys_addr_t phys, unsigned long virt,
>>  			     int flags);
>>  #endif
>>  
>> +#define INVALID_PHYS_ADDR	-1
> 
> Nitpick: (-1UL) (or (-1ULL), KVM_PHYS_INVALID is defined as the latter).

Fair. Will fix.

> 
> Otherwise the patch looks fine.
> 
> Reviewed-by: Catalin Marinas <catalin.marinas at arm.com>

Cheers! But I think we need to solve the issue where code is ignoring the error
code problem that Dev raised before merging this.



More information about the linux-arm-kernel mailing list