[PATCH RESEND 05/14] gpio: ts4800: use generic device properties

Bartosz Golaszewski brgl at bgdev.pl
Wed Sep 3 09:12:20 PDT 2025


On Wed, Sep 3, 2025 at 5:41 PM Andy Shevchenko
<andriy.shevchenko at intel.com> wrote:
>
> On Mon, Aug 25, 2025 at 11:48:46AM +0200, Bartosz Golaszewski wrote:
> >
> > Avoid pulling in linux/of.h by using the generic device properties.
>
> ...
>
> > -     retval = of_property_read_u32(node, "ngpios", &ngpios);
> > +     retval = device_property_read_u32(dev, "ngpios", &ngpios);
> >       if (retval == -EINVAL)
> >               ngpios = DEFAULT_PIN_NUMBER;
> >       else if (retval)
>
> Don't we have a method in GPIOLIB that does this (can be called explicitly by the drivers)?
>

Sure but we don't have the same behavior in GPIO core, we don't know
what DEFAULT_PIN_NUMBER is. I can't test this functionally so don't
want to change semantics.

Bart



More information about the linux-arm-kernel mailing list