[PATCH RESEND 09/14] gpio: dwapb: use new generic GPIO chip API

Andy Shevchenko andriy.shevchenko at intel.com
Wed Sep 3 08:51:07 PDT 2025


On Mon, Aug 25, 2025 at 11:48:50AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski at linaro.org>
> 
> Convert the driver to using the new generic GPIO chip interfaces from
> linux/gpio/generic.h.

...

> +static inline struct dwapb_gpio *to_dwapb_gpio(struct gpio_chip *gc)
> +{
> +	return container_of(to_gpio_generic_chip(gc),
> +			    struct dwapb_gpio_port, chip)->gpio;
> +}

Since it's not a macro anymore it can be done better:

	struct dwapb_gpio_port *port;

	port = container_of(to_gpio_generic_chip(gc), struct dwapb_gpio_port, chip);
	return port->gpio;

Also, have you checked the bloat-o-meter before and after, wondering if we gain
something with this.

-- 
With Best Regards,
Andy Shevchenko





More information about the linux-arm-kernel mailing list