[PATCH] arm64: dts: mediatek: mt8183: Fix out of range pull values

Chen-Yu Tsai wenst at chromium.org
Tue Sep 2 21:10:58 PDT 2025


On Wed, Sep 3, 2025 at 9:53 AM Rob Herring <robh at kernel.org> wrote:
>
> On Wed, Jul 23, 2025 at 3:16 AM AngeloGioacchino Del Regno
> <angelogioacchino.delregno at collabora.com> wrote:
> >
> > Il 22/07/25 19:11, Rob Herring (Arm) ha scritto:
> > > A value of 10 is not valid for "mediatek,pull-down-adv" and
> > > "mediatek,pull-up-adv" properties which have defined values of 0-3. It
> > > appears the "10" was written as a binary value. The driver only looks at
> > > the lowest 2 bits, so the value "10" decimal works out the same as if
> > > "2" was used.
> > >
> > > Fixes: cd894e274b74 ("arm64: dts: mt8183: Add krane-sku176 board")
> > > Fixes: 19b6403f1e2a ("arm64: dts: mt8183: add mt8183 pumpkin board")
> > > Signed-off-by: Rob Herring (Arm) <robh at kernel.org>
> > > ---
> > > This is just a few of the warnings related to mt8183-pinctrl... Mediatek
> > > is #1 for DT warnings on arm64. And by #1, I mean worst. :( It would be
> > > nice to see some progress on fixing them. Otherwise, seeing new Mediatek
> > > bindings rather than fixing the existing stuff makes me grumpy.
> > >
> >
> > Thanks for this fix.
> >
> > You're absolutely right about this, let me check what I can do (and if I can get
> > some colleague(s) of mine to look at that while I'm away in August).
> >
> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>
>
> Is this going to get applied and into linux-next sometime soon? Only
> been like 6 weeks...

AFAIK Angelo is on vacation but should be back shortly in September.



More information about the linux-arm-kernel mailing list