[PATCH 3/3] watchdog: visconti: don't print superfluous errors

[nobuhiro.iwamatsu.x90 at mail.toshiba]

Hello,

> -----Original Message-----
> From: Wolfram Sang <wsa+renesas at sang-engineering.com>
> Sent: Thursday, August 14, 2025 4:05 AM
> To: linux-watchdog at vger.kernel.org
> Cc: Wolfram Sang <wsa+renesas at sang-engineering.com>; Wim Van
> Sebroeck <wim at linux-watchdog.org>; Guenter Roeck <linux at roeck-us.net>;
> iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○ＣＰＴ)
> <nobuhiro1.iwamatsu at toshiba.co.jp>; linux-arm-kernel at lists.infradead.org
> Subject: [PATCH 3/3] watchdog: visconti: don't print superfluous errors
> 
> The watchdog core will handle error messages already.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas at sang-engineering.com>
> ---
>  drivers/watchdog/visconti_wdt.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/watchdog/visconti_wdt.c
> b/drivers/watchdog/visconti_wdt.c index cef0794708e7..7795e7fbf67e 100644
> --- a/drivers/watchdog/visconti_wdt.c
> +++ b/drivers/watchdog/visconti_wdt.c
> @@ -118,7 +118,6 @@ static int visconti_wdt_probe(struct platform_device
> *pdev)
>  	struct visconti_wdt_priv *priv;
>  	struct device *dev = &pdev->dev;
>  	struct clk *clk;
> -	int ret;
>  	unsigned long clk_freq;
> 
>  	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); @@ -153,9
> +152,7 @@ static int visconti_wdt_probe(struct platform_device *pdev)
>  	watchdog_stop_on_unregister(wdev);
> 
>  	/* This overrides the default timeout only if DT configuration was
> found */
> -	ret = watchdog_init_timeout(wdev, 0, dev);
> -	if (ret)
> -		dev_warn(dev, "Specified timeout value invalid, using
> default\n");
> +	watchdog_init_timeout(wdev, 0, dev);
> 
>  	return devm_watchdog_register_device(dev, wdev);  }

Reviewed-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90 at mail.toshiba>

Best regards,
  Nobuhiro