[PATCH 2/8] ARM: dts: bcm63138: Fix RNG and DMA IRQs

William Zhang william.zhang at broadcom.com
Mon Sep 1 15:22:13 PDT 2025


Hi Linus,

On Mon, Sep 1, 2025 at 5:50 AM Linus Walleij <linus.walleij at linaro.org> wrote:
>
> The RNG and DMA IRQs are wrong: these begin at
> ISR_TABLE3_OFFSET at 94, and are at 94+21 and 94+23
ISR_TABLE3_OFFSET is 96 in the legacy 63138_intr.h.
INTERRUPT_ID_RNG is (ISR_TABLE3_OFFSET + 21)
which is 117. Converting back dtsi SPI interrupt is 117-32 = 85
So the original value is correct.  DMA interrupt number need to
be corrected to 87.

Please note there is some inconsistent definition of the ISR table
offset between chips.   But whatever their number is,  the dts SPI interrupt
is always equal to INTERRUPT_ID - 32.

> respectively.
>
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> ---
>  arch/arm/boot/dts/broadcom/bcm63138.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/broadcom/bcm63138.dtsi b/arch/arm/boot/dts/broadcom/bcm63138.dtsi
> index 4ec568586b14c89daceddea8f17381f72f512a93..d7410bb1b5a8e221d7ca1f2f299ce6d2bc40b763 100644
> --- a/arch/arm/boot/dts/broadcom/bcm63138.dtsi
> +++ b/arch/arm/boot/dts/broadcom/bcm63138.dtsi
> @@ -244,7 +244,7 @@ gpio4: gpio at 110 {
>                 rng at 300 {
>                         compatible = "brcm,iproc-rng200";
>                         reg = <0x300 0x28>;
> -                       interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
> +                       interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
>                 };
>
>                 serial0: serial at 600 {
> @@ -317,7 +317,7 @@ pl081_dma: dma-controller at d000 {
>                         // The magic B105F00D info is missing
>                         arm,primecell-periphid = <0x00041081>;
>                         reg = <0xd000 0x1000>;
> -                       interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> +                       interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
>                         memcpy-burst-size = <256>;
>                         memcpy-bus-width = <32>;
>                         clocks = <&periph_clk>;
>
> --
> 2.50.1
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4199 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20250901/ac5c2ab2/attachment.p7s>


More information about the linux-arm-kernel mailing list