[PATCH v3 8/9] media: qcom: camss: Add support for VFE 690
Vikram Sharma
quic_vikramsa at quicinc.com
Mon Sep 1 02:56:21 PDT 2025
On 9/1/2025 2:34 PM, Bryan O'Donoghue wrote:
> On 03/07/2025 18:19, Vikram Sharma wrote:
>> + !strcmp(clock->name, "camnoc_axi"));
>
> This is causing a regression on other platforms because they define
> camnnoc_axi but not @ the rate of the pixel clock.
>
> In fact its not very obvious why the CAMNOC AXI would want to have a
> pixel clock applied to the interconnect fabric.
>
> The following resolves the regression for me. I can either merge with
> this change or I'll have to drop the VFE690 changes until you come
> back with something else.
Hi Bryan,
updating camnoc axi to 400Mhz was required for TPG test case.
As of now you can Merge VFE patch with below change.
Meanwhile I will work on an alternative approach to set camnoc_axi and
submit as a separate patch.
>
> ➜ deckard at sagittarius-a ~/Development/qualcomm/qlt-kernel
> git:(aaa8b5ab704f3) ✗ git diff
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c
> b/drivers/media/platform/qcom/camss/camss-vfe.c
> index e969de74818f1..1aa0ba5ad8d60 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
> @@ -913,8 +913,7 @@ static int vfe_match_clock_names(struct vfe_device
> *vfe,
>
> return (!strcmp(clock->name, vfe_name) ||
> !strcmp(clock->name, vfe_lite_name) ||
> - !strcmp(clock->name, "vfe_lite") ||
> - !strcmp(clock->name, "camnoc_axi"));
> + !strcmp(clock->name, "vfe_lite"));
>
> ---
> bod
Best regards,
Vikram
>
More information about the linux-arm-kernel
mailing list