[PATCH 2/4] thermal: qoriq: add i.MX93 TMU support
Krzysztof Kozlowski
krzk at kernel.org
Tue Jul 29 01:07:54 PDT 2025
On 29/07/2025 10:02, Jacky Bai wrote:
>> Subject: Re: [PATCH 2/4] thermal: qoriq: add i.MX93 TMU support
>>
> ...
>
>>> +325,9 @@ static int qoriq_tmu_probe(struct platform_device *pdev)
>>>
>>> data->ver = (ver >> 8) & 0xff;
>>>
>>> + if (of_find_compatible_node(NULL, NULL, "fsl,imx93-tmu"))
>>> + data->ver = TMU_VER93;
>>
>> No, you have driver match data for this.
>>
>
> No compatible specific data info provided in the driver, will use
> the 'of_device_is_compatible' to refine the above changes.
Again, no. This does not scale, use standard methods.
NAK
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list