[PATCH v4 06/10] dt-bindings: clock: Add required "interconnect-cells" property

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Fri Aug 29 00:37:02 PDT 2025


On Thu, Aug 28, 2025 at 06:32:19PM +0800, Luo Jie wrote:
> ICC clocks are always provided by the NSS clock controller of IPQ9574,
> so add interconnect-cells as required DT property.

Does not make sense. If clocks are always, you require different
property?

> 
> Fixes: 28300ecedce4 ("dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions")
> Signed-off-by: Luo Jie <quic_luoj at quicinc.com>

Fixes cannot be in the middle of patchset.

See submitting patches and your internal guideline explaining it with
great details.

> ---
>  Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
> index 17252b6ea3be..fc604279114f 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
> @@ -57,6 +57,7 @@ required:
>    - compatible
>    - clocks
>    - clock-names
> +  - '#interconnect-cells'

ABI break without explanation.

Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list