[PATCH v3 2/3] pinctrl: bcm: Add STB family pin controller driver

[Florian Fainelli]

On 8/19/25 02:18, Stefan Wahren wrote:
> Hi Andrea,
> 
> Am 11.08.25 um 16:46 schrieb Andrea della Porta:
>> From: "Ivan T. Ivanov" <iivanov at suse.de>
>>
>> This driver provide pin muxing and configuration functionality
>> for BCM2712 SoC used by RPi5. According to [1] this chip is an
>> instance of the one used in Broadcom STB  product line.
> i'm not sure about the whole driver naming. The cover letter describe it 
> as "pin control driver for BCM2712 SoC", but this patch is described as 
> "STB family pin controller driver". So as a reviewer, I'm a little bit 
> confused of the domain of this driver. Is it for a single SoC or really 
> for a whole family of many SoCs?

The structure of the driver is applicable to the entire Broadcom STB SoC 
family, of which 2712/7712 is one instance.

> 
> I'm asking because all the other BCM pinctrl drivers are mostly SoC 
> specific and not really general for a product line.
> 
> In the former case, I would expect a driver name like pinctrl-bcm2712 to 
> make it more clear.

pinctrl-brcmstb.c for the main part which is agnostic to the 
chip-specific functions is adequate.
-- 
Florian