[PATCH v4 1/2] dt-bindings: ethernet: eswin: Document for EIC7700 SoC
Krzysztof Kozlowski
krzk at kernel.org
Wed Aug 27 05:48:58 PDT 2025
On 27/08/2025 10:13, weishangjuan at eswincomputing.com wrote:
> + clocks:
> + items:
> + - description: GMAC main clock
> + - description: Tx clock
> + - description: AXI clock
> + - description: Configuration clock
> +
> + clock-names:
> + contains:
This part did not improve:
items: instead
> + enum:
> + - axi
> + - cfg
> + - stmmaceth
> + - tx
> +
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + items:
> + - const: stmmaceth
> +
> + rx-internal-delay-ps:
> + enum: [0, 200, 600, 1200, 1600, 1800, 2000, 2200, 2400]
> +
> + tx-internal-delay-ps:
> + enum: [0, 200, 600, 1200, 1600, 1800, 2000, 2200, 2400]
> +
> + eswin,hsp-sp-csr:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + items:
> + - description: Phandle to HSP(High-Speed Peripheral) device
> + - description: Offset of phy control register for internal
> + or external clock selection
> + - description: Offset of AXI clock controller Low-Power request
> + register
> + - description: Offset of register controlling TX/RX clock delay
> + description: |
> + A phandle to hsp-sp-csr with three arguments that configure
> + HSP(High-Speed Peripheral) device. The argument one is the
> + offset of phy control register for internal or external clock
> + selection, the argument two is Offset of AXI clock controller
> + Low-Power request register, the argument three is Offset of
> + register controlling TX/RX clock delay.
Description is mostly redundant - it is already part of items:. Just say
here "HSP (High Spee....) device needed to configure clock selection,
clock low-power mode and clock delay." or something similar.
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
Best regards,
Krzysztof
More information about the linux-arm-kernel
mailing list