[PATCH v4 01/13] spi: airoha: return an error for continuous mode dirmap creation cases
Lorenzo Bianconi
lorenzo at kernel.org
Sat Aug 23 01:04:19 PDT 2025
> This driver can accelerate single page operations only, thus
> continuous reading mode should not be used.
>
> Continuous reading will use sizes up to the size of one erase block.
> This size is much larger than the size of single flash page. Use this
> difference to identify continuous reading and return an error.
>
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy at iopsys.eu>
> Reviewed-by: Frieder Schrempf <frieder.schrempf at kontron.de>
I guess here we need to add the proper Fixes tag:
Fixes: a403997c12019 ("spi: airoha: add SPI-NAND Flash controller driver")
> ---
> drivers/spi/spi-airoha-snfi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c
> index dbe640986825..043a03cd90a1 100644
> --- a/drivers/spi/spi-airoha-snfi.c
> +++ b/drivers/spi/spi-airoha-snfi.c
> @@ -618,6 +618,10 @@ static int airoha_snand_dirmap_create(struct spi_mem_dirmap_desc *desc)
> if (desc->info.offset + desc->info.length > U32_MAX)
> return -EINVAL;
>
> + /* continuous reading is not supported */
> + if (desc->info.length > SPI_NAND_CACHE_SIZE)
> + return -E2BIG;
> +
> if (!airoha_snand_supports_op(desc->mem, &desc->info.op_tmpl))
> return -EOPNOTSUPP;
>
> --
> 2.50.1
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20250823/3976e01b/attachment.sig>
More information about the linux-arm-kernel
mailing list