[PATCH net-next v13 4/5] net: ti: prueth: Adds link detection, RX and TX support.

[Parvathi Pudi]

Hi,

> On Wed, 20 Aug 2025 18:38:17 +0530 (IST) Parvathi Pudi wrote:
>> > On Mon, 18 Aug 2025 18:39:37 +0530 (IST) Parvathi Pudi wrote:
>> >> +       if (num_rx_packets < budget && napi_complete_done(napi, num_rx_packets))
>> >>                 enable_irq(emac->rx_irq);
>> >> -       }
>> >>  
>> >>         return num_rx_packets;
>> >>  }
>> >> 
>> >> We will address this in the next version.
>> > 
>> > Ideally:
>> > 
>> >	if (num_rx < budget && napi_complete_done()) {
>> >		enable_irq();
>> >		return num_rx;
>> >	}
>> > 
>> > 	return budget;
>> 
>> However, if num_rx < budget and if napi_complete_done() is false, then
>> instead of returning the num_rx the above code will return budget.
>> 
>> So, unless I am missing something, the previous logic seems correct to me.
>> Please let me know otherwise.
> 
> IIRC either way is fine, as long as num_rx doesn't go over budget.

Sure. We will address this in the next version.


Thanks and Regards,
Parvathi.