[PATCH v3 1/2] dt-bindings: mfd: add Traverse Ten64 board controller

[Mathew McBride]

Hi Krzysztof,

Thank for your feedback.

On Thu, Aug 21, 2025, at 4:19 PM, Krzysztof Kozlowski wrote:
> On 21/08/2025 08:11, Mathew McBride wrote:
> > Add device tree binding for the board (micro)controller on Ten64 family
> > boards[1].
> > 
> 
> Do not attach (thread) your patchsets to some other threads (unrelated
> or older versions). This buries them deep in the mailbox and might
> interfere with applying entire sets.
> 
Understood, my apologies.

> > The schema is simple and is (presently) only consumed by U-Boot, but it
> > is possible that it could be consumed by nvmem or other type drivers in
> > the future, as well as extended to future Traverse boards.
> > 
> > The categorisation as a "MFD" follows that of comparable devices such
> > as "gw,gsc", "google,chros-ec" and "kontron,sl28cpld".
> 
> That is not MFD device. Google EC is for example, but you have only one
> function. I think we will move all of them to some separate ec directory.

Noted, I will wait for that change to progress before moving any further with this.

Hypothetically, the ten64-controller may acquire some sort of "child" binding such as
watchdog and nvmem in the future, similar to the other "EC" devices, there just has not
been a need to do so yet.

[snip]

> > +  Communication between the SoC and controller is via I2C, at a fixed address
> 
> Either you make it a schema or drop it.
Is this in reference to the "fixed address"? In which case, I'll remove references to any fixed address.
> 
> > +  of 0x7e. While the controller firmware implements several functions, there
> > +  are presently no parameters that are configurable by DT properties, except
> > +  those that are required of an I2C bus endpoint.
> 
> This paragraph wasn't here before. It's completely redundant, drop.
Will be removed as noted above.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> 
> Best regards,
> Krzysztof
> 

Many Thanks,
Matt