[PATCH v2 00/12] media: imx-mipi-csis: Cleanups and debugging improvements
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Wed Aug 20 17:09:32 PDT 2025
Hello,
This patch series bring a few miscellaneous improvements to the
imx-mipi-csis driver, and in particular improves the debugging
infrastructure.
Patch 01/12 starts by making the v4l2_get_link_freq() function accept a
const media_pad argument. This conflicts with [1], I don't mind rebasing
on top of it. Sakari, if you plan to get that patch merged soon, feel
free to take 01/12 too.
The next three patches, 02/12 to 04/12, are small cleanups. They are new
in this version of the series. Patch 05/12 then aligns the code with the
reference manual for register field names, increasing readability of the
driver when read alongside the hardware documentation. Patch 06/12 fixes
a small alignment issue in register dumps, and patch 07/12 logs per-lane
start of transmission error instead of supporting the first data lane
only, easing debugging of D-PHY issues.
The next two patches deprecate the clock-frequency DT property, which
shouldn't have been added in the first place. Patch 08/12 improves
handling of the clock frequency in the driver, and patch 09/12
deprecates the property in the DT bindings. The driver still supports
the property to ensure backward compatibility.
The last three patches introduce support for multiple output channels
and wire it up in the debugging infrastructure. The CSIS IP core
supports up to 4 output channels, with the number of instantiated
channels being a property of the SoC integration. So far, only the
i.MX8MP is known to have multiple output channels. Patch 10/12 adds a
corresponding DT property, and patch 11/12 adds initial support for that
property in the driver, and uses it to dump per-channel registers and
event counters. Finally, patch 12/12 sets the property in the i.MX8MP
DT.
[1] https://lore.kernel.org/linux-media/20250819094533.2335-3-sakari.ailus@linux.intel.com
Laurent Pinchart (12):
media: v4l2-common: Constify media_pad argument to
v4l2_get_link_freq()
media: imx-mipi-csis: Simplify access to source pad
media: imx-mipi-csis: Standardize const keyword placement
media: imx-mipi-csis: Shorten name of subdev state variables
media: imx-mipi-csis: Rename register macros to match reference manual
media: imx-mipi-csis: Fix field alignment in register dump
media: imx-mipi-csis: Log per-lane start of transmission errors
media: imx-mipi-csis: Only set clock rate when specified in DT
dt-bindings: media: nxp,imx-mipi-csi2: Mark clock-frequency as
deprecated
dt-bindings: media: nxp,imx-mipi-csi2: Add fsl,num-channels property
media: imx-mipi-csis: Initial support for multiple output channels
arm64: dts: imx8mp: Specify the number of channels for CSI-2 receivers
.../bindings/media/nxp,imx-mipi-csi2.yaml | 18 +-
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +
drivers/media/platform/nxp/imx-mipi-csis.c | 348 +++++++++++-------
drivers/media/v4l2-core/v4l2-common.c | 2 +-
include/media/v4l2-common.h | 3 +-
5 files changed, 230 insertions(+), 143 deletions(-)
base-commit: a75b8d198c55e9eb5feb6f6e155496305caba2dc
--
Regards,
Laurent Pinchart
More information about the linux-arm-kernel
mailing list