[PATCH net-next v2 3/3] net: stmmac: Set CIC bit only for TX queues with COE

G Thomas, Rohan rohan.g.thomas at altera.com
Wed Aug 20 00:14:18 PDT 2025


Hi Jakub,

Thanks for reviewing the patch.

On 8/20/2025 6:52 AM, Jakub Kicinski wrote:
> On Sat, 16 Aug 2025 00:55:25 +0800 Rohan G Thomas via B4 Relay wrote:
>> +	bool csum = !priv->plat->tx_queues_cfg[queue].coe_unsupported;
> 
> Hopefully the slight pointer chasing here doesn't impact performance?
> XDP itself doesn't support checksum so perhaps we could always pass
> false?

I'm not certain whether some XDP applications might be benefiting from
checksum offloading currently, and so passing false unconditionally
could cause regressions.

Best Regards,
Rohan




More information about the linux-arm-kernel mailing list