[PATCH v2 3/3] arm64: dts: rockchip: update pinctrl names for Radxa E52C
Chukun Pan
amadeus at jmu.edu.cn
Tue Aug 19 08:00:38 PDT 2025
Hi,
> "The name of a node should be somewhat generic".
>
> https://github.com/devicetree-org/devicetree-specification/blob/v0.4/source/chapter2-devicetree-basics.rst?plain=1#L193
Usually we use the name on the schematic. For example, the patch for e24c:
https://lore.kernel.org/lkml/20250727144409.327740-4-jonas@kwiboo.se/
```
+ gpio-keys {
+ compatible = "gpio-keys";
+ pinctrl-names = "default";
+ pinctrl-0 = <&gpio0_a0_user>;
```
If this is incorrect, I will abandon the pinctrl changes for
the user key and power LED.
> > - vcc_5v0_pwren_h: regulator-5v0-1 {
> > - usb_otg_pwren_h: regulator-5v0-0 {
But I don't think the above is correct.
> https://lore.kernel.org/all/20241216113052.15696-1-naoki@radxa.com/T/#u
>
> (I don't understand why this only applies to me...)
I don't know this. I thought the nodenames of pinctrl and regulator
were a bit weird, so I changed the pinctrl's.
Thanks,
Chukun
--
2.25.1
More information about the linux-arm-kernel
mailing list