[PATCH] pinctrl: single: fix bias pull up/down handling in pin_config_set

[Linus Walleij]

On Thu, Aug 7, 2025 at 8:42 AM Chi Zhang <chizhang at asrmicro.com> wrote:

> In the pin_config_set function, when handling PIN_CONFIG_BIAS_PULL_DOWN or
> PIN_CONFIG_BIAS_PULL_UP, the function calls pcs_pinconf_clear_bias()
> which writes the register. However, the subsequent operations continue
> using the stale 'data' value from before the register write, effectively
> causing the bias clear operation to be overwritten and not take effect.
>
> Fix this by reading the 'data' value from the register after calling
> pcs_pinconf_clear_bias().
>
> This bug seems to have existed when this code was first merged in commit
> 9dddb4df90d1 ("pinctrl: single: support generic pinconf").
>
> Signed-off-by: Chi Zhang <chizhang at asrmicro.com>

No replies from maintainers so patch applied!

Yours,
Linus Walleij