[PATCH v2 1/3] i2c: add init_recovery() callback
Andy Shevchenko
andriy.shevchenko at linux.intel.com
Mon Aug 11 13:17:41 PDT 2025
On Mon, Aug 11, 2025 at 09:49:55PM +0200, Gabor Juhos wrote:
> Add a new init_recovery() callback to struct 'i2c_bus_recovery_info'
> and modify the i2c_init_recovery() function to call that if specified
> instead of the generic i2c_gpio_init_recovery() function.
>
> This allows controller drivers to skip calling the generic code by
> implementing a dummy callback function, or alternatively to run a
> fine tuned custom implementation.
>
> This is needed for the 'i2c-pxa' driver in order to be able to fix
> a long standing bug for which the fix will be implemented in a
> followup patch.
"...next change."
...
The first traditional question is why the generic recovery is not working.
...
> - if (i2c_gpio_init_recovery(adap) == -EPROBE_DEFER)
> + if (bri->init_recovery) {
> + ret = bri->init_recovery(adap);
> + if (ret)
> + return ret;
> + } else if (i2c_gpio_init_recovery(adap) == -EPROBE_DEFER) {
> return -EPROBE_DEFER;
> + }
If the above stays, I think we would drop the last and always have
init_recovery to be assigned.
--
With Best Regards,
Andy Shevchenko
More information about the linux-arm-kernel
mailing list