[PATCH] mailbox: arm_mhuv3: Remove no_free_ptr() to maintain the original form of the pointer
Cristian Marussi
cristian.marussi at arm.com
Mon Aug 11 02:30:51 PDT 2025
On Mon, Aug 11, 2025 at 04:25:36PM +0800, Liao Yuanhong wrote:
> Remove no_free_ptr() to ensure PTR_ERR() consistently retrieves the correct
> error code.
>
Hi,
> Signed-off-by: Liao Yuanhong <liaoyuanhong at vivo.com>
> ---
> drivers/mailbox/arm_mhuv3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mailbox/arm_mhuv3.c b/drivers/mailbox/arm_mhuv3.c
> index b97e79a5870f..0910da67f8a1 100644
> --- a/drivers/mailbox/arm_mhuv3.c
> +++ b/drivers/mailbox/arm_mhuv3.c
> @@ -945,7 +945,7 @@ static irqreturn_t mhuv3_mbx_comb_interrupt(int irq, void *arg)
> if (IS_ERR(data)) {
> dev_err(dev,
> "Failed to read in-band data. err:%ld\n",
> - PTR_ERR(no_free_ptr(data)));
> + PTR_ERR(data));
> goto rx_ack;
Yes indeed the cleanup kfree helper takes care to skip any ERR_OR_NULL
by itself...good catch, thanks for this.
Acked-by: Cristian Marussi <cristian.marussi at arm.com>
Thanks,
Cristian
More information about the linux-arm-kernel
mailing list