[PATCH 8/9] arm64: dts: mediatek: mt8183-kukui: Fix pull-down/up-adv values
AngeloGioacchino Del Regno
angelogioacchino.delregno at collabora.com
Mon Aug 4 00:59:23 PDT 2025
Il 01/08/25 13:18, Julien Massot ha scritto:
> The properties `mediatek,pull-up-adv` and `mediatek,pull-down-adv`
> were using incorrect values like `<10>` and `<01>`. These values
> are parsed as decimal (10 and 1 respectively), not binary.
>
> However, the driver interprets these as bitfields:
> - BIT(0): R0
> - BIT(1): R1
>
> So valid values are:
> - 0 => no pull
> - 1 => enable R0
> - 2 => enable R1
> - 3 => enable R0 + R1
>
> Using `<10>` is invalid as it exceeds the accepted range.
> It was likely intended as binary `0b10` (i.e., `2`),
> to enable R1 only.
>
> This patch replaces incorrect values with the correct ones
> and removes the leading zero from `<01>` to avoid confusion
> with bitfield notation.
>
> Signed-off-by: Julien Massot <julien.massot at collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>
More information about the linux-arm-kernel
mailing list