[PATCH RESEND, v6 6/8] mailbox: mediatek: Add CMDQ secure mailbox driver

[Jason-JH Lin (林睿祥)]

Hi CK,

On Tue, 2024-05-28 at 03:17 +0000, CK Hu (胡俊光) wrote:
> Hi, Jason:
> 
> On Sun, 2024-05-26 at 22:44 +0800, Jason-JH.Lin wrote:
> > To support secure video path feature, GCE have to read/write
> > registgers
> > in the secure world. GCE will enable the secure access permission
> > to the
> > HW who wants to access the secure content buffer.
> > 
> > Add CMDQ secure mailbox driver to make CMDQ client user is able to
> > sending their HW settings to the secure world. So that GCE can
> > execute
> > all instructions to configure HW in the secure world.
> > 
> > TODO:
> > 1. Squash cmdq_sec_task_exec_work() into cmdq_sec_mbox_send_data().
> > 2. Call into TEE to query cookie instead of using shared memory in
> >    cmdq_sec_get_cookie().
> > 3. Register shared memory as command buffer instead of copying
> > normal
> >    command buffer to IWC shared memory.
> > 4. Use SOFTDEP to make cmdq_sec_probe later than OPTEE loaded and
> > then
> >    move cmdq_sec_session_init into cmdq_sec_probe().
> > 5. Remove timeout detection in cmdq_sec_session_send().
> > 
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin at mediatek.com>
> > Signed-off-by: Hsiao Chien Sung <shawn.sung at mediatek.com>
> > ---
> 
> [snip]
> 
> > +/**
> > + * struct readback_engine - readback engine parameters.
> > + * @engine: HW engine flag for readback.
> > + * @start: start address pa of readback buffer.
> > + * @count: u32 size count of readback buffer.
> > + * @param: other parameters need in secure world.
> > + */
> > +struct readback_engine {
> > +	u32 engine;
> > +	u32 start;
> > +	u32 count;
> > +	u32 param;
> > +};
> 
> Useless, so drop it.
> 
OK, I'll drop this.

Regards,
Jason-JH.Lin

> Regards,
> CK