[PATCH] MAINTAINERS: perf: arm64: Catch all Arm files and folders

James Clark james.clark at arm.com
Thu May 16 03:36:21 PDT 2024



On 16/05/2024 06:35, Anshuman Khandual wrote:
> 
> 
> On 5/15/24 20:42, James Clark wrote:
>> Catch all files and folders with Arm in the name in tools/perf/ up to
>> two levels deep. There currently no false positives.
>>
>> This catches lots of missing items like these and more:
>>
>>   * util/arm-spe-decoder/
>>     (The existing util/arm-spe* entry only matched files not folders)
>>   * util/perf-regs-arch/perf_regs_arm.c
>>   * scripts/python/arm-cs-trace-disasm.py
>>   * tests/shell/test_arm_spe.sh
> 
> Agreed.
> 
>>
>> Signed-off-by: James Clark <james.clark at arm.com>
>> ---
>>  MAINTAINERS | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index ec0284125e8f..c5d0256d32dd 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -17318,9 +17318,10 @@ R:	Leo Yan <leo.yan at linux.dev>
>>  L:	linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
>>  S:	Supported
>>  F:	tools/build/feature/test-libopencsd.c
>> -F:	tools/perf/arch/arm*/
>> -F:	tools/perf/pmu-events/arch/arm64/
>> -F:	tools/perf/util/arm-spe*
>> +F:	tools/perf/*/*/*arm*
>> +F:	tools/perf/*/*/*arm*/
>> +F:	tools/perf/*/*arm*
>> +F:	tools/perf/*/*arm*/
>>  F:	tools/perf/util/cs-etm*
> 
> Very minor nit, these regular expressions should be arranged as per
> the increasing directory depth levels, just to make it apparent in
> terms of which files are being covered here ?
> 
> F:	tools/perf/*/*arm*
> F:	tools/perf/*/*arm*/
> F:	tools/perf/*/*/*arm*
> F:	tools/perf/*/*/*arm*/
> 

Checkpatch has an alphabetical sort which says they have to be the other
way around, but yes I agree I did write it your way initially.

> But regardless, with or without the above changes
> 
> Reviewed-by: Anshuman Khandual <anshuman.khandual at arm.com>
> 
>>  
>>  PERSONALITY HANDLING



More information about the linux-arm-kernel mailing list