[PATCH v3] clk: samsung: exynos-clkout: Remove misleading of_match_table/MODULE_DEVICE_TABLE

William McVicker willmcvicker at google.com
Mon May 13 00:19:01 PDT 2024


On 05/10/2024, Sam Protsenko wrote:
> On Fri, May 10, 2024 at 2:07 AM Marek Szyprowski
> <m.szyprowski at samsung.com> wrote:
> >
> > Since commit 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to
> > module driver") this driver is instantiated as MFD-cell (matched by
> > platform device name) not as a real platform device created by OF code.
> > Remove then of_match_table and change related MODULE_DEVICE_TABLE to
> > simple MODULE_ALIAS to avoid further confusion.
> >
> > Signed-off-by: Marek Szyprowski <m.szyprowski at samsung.com>
> > ---
> > v3:
> > - Use '#define DRV_NAME' based alias. I see no point bloating the driver
> > with another platform device IDs array, as I don't expect this driver to
> > be used with any other platform device ID. Driver variants are already
> > selected based on the parent PMU device compatible.

Sure, I'm fine with this either way. Thanks for following up!

> >
> > v2:
> > - added MODULE_ALIAS
> > ---
> 
> Reviewed-by: Sam Protsenko <semen.protsenko at linaro.org>

Reviewed-by: Will McVicker <willmcvicker at google.com>

> 
> [snip]



More information about the linux-arm-kernel mailing list