[PATCH bpf-next v3 0/3] Support kCFI + BPF on arm64

Puranjay Mohan puranjay12 at gmail.com
Wed May 8 03:05:30 PDT 2024


Maxwell Bland <mbland at motorola.com> writes:

Hi Maxwell,

> In preparation for the BPF summit, I took a look back on BPF-CFI patches
> to check the status and found that there had been no updates for around
> a month, so I went ahead and made the fixes suggested in v2.
>
> This patchset handles emitting proper CFI hashes during JIT, which
> can cause some of the selftests to fail, and handles removing the
> __nocfi tag from bpf_dispatch_*_func on ARM, meaning Clang CFI 
> checks will be generated:
>
> 0000000000fea1e8 <bpf_dispatcher_xdp_func>:
> paciasp
> stp     x29, x30, [sp, #-0x10]!
> mov     x29, sp
> + ldur    w16, [x2, #-0x4]                           
> + movk    w17, #0x1881                               
> + movk    w17, #0xd942, lsl #16                      
> + cmp     w16, w17                                
> + b.eq    0xffff8000810016a0 <bpf_dispatcher_xdp_func+0x24>
> + brk     #0x8222   
> blr     x2
> ldp     x29, x30, [sp], #0x10
> autiasp
> ret
>
> Where ^+ indicates the additional assembly.
>
> Credit goes to Puranjay Mohan entirely for this, I just did some fixes,
> hopefully that is OK.

Thanks for taking this effort forward.

checkpatch.pl complains about the patches like the following:

ERROR: Missing Signed-off-by: line by nominal patch author 'Maxwell Bland <mbland at motorola.com>'

So, you can change the authorship of the patch like:

git commit --amend --author "Puranjay Mohan <puranjay12 at gmail.com>"

similar for the patch by Mark:

git commit --amend --author "Mark Rutland <mark.rutland at arm.com>"

Thanks,
Puranjay



More information about the linux-arm-kernel mailing list