[PATCH RESEND] arm64: dts: marvell: add DTS for 7215-IXS-A1 board

[Andrew Lunn]

> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2024 Nokia
> + * Copyright (C) 2020 Marvell International Ltd.
> + */
> +
> +#include "cn9130.dtsi" /* include SoC device tree */
> +
> +#include <dt-bindings/gpio/gpio.h>
> +
> +/ {
> +	#address-cells = <0x02>;
> +	#size-cells = <0x02>;
> +	model = "7215 IXS-A1";
> +	compatible = "marvell,cn9130\0marvell,armada-ap807-quad\0marvell,armada-ap807";

Could you please explain the \0 ?

Also, there is generally a compatible which has something to do with
the actual product, 7215 IXS-A1, not just the RDK it is based on.

> +&cp0_mdio {
> +	status = "okay";
> +	phy0: ethernet-phy at 0 {
> +		reg = <0>;
> +		/* Management port LED blink activity*/
> +		marvell,reg-init = <0x03 0x10 0x0 0x1140>;

Please configure this via /sys/class/leds. Take a look at armada 370
rd for an example for what you need in DT.

> diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile
> index 99b8cb3c49e1..124a7d1fd5a8 100644
> --- a/arch/arm64/boot/dts/marvell/Makefile
> +++ b/arch/arm64/boot/dts/marvell/Makefile
> @@ -28,3 +28,4 @@ dtb-$(CONFIG_ARCH_MVEBU) += cn9130-crb-A.dtb
>  dtb-$(CONFIG_ARCH_MVEBU) += cn9130-crb-B.dtb
>  dtb-$(CONFIG_ARCH_MVEBU) += ac5x-rd-carrier-cn9131.dtb
>  dtb-$(CONFIG_ARCH_MVEBU) += ac5-98dx35xx-rd.dtb
> +dtb-$(CONFIG_ARCH_MVEBU) += 7215-ixs-a1.dtb

This file is sorted alphabetically. It is not so important for this
file, but Makefiles which see a lot of changed get merge conflicts if
you always add at the end. By keeping it in alphabetic order it tends
to spread changes out so they are less likely to cause such conflicts.

Also, maybe this should be nokia-7215-ixs-a1.dtb?

      Andrew