[PATCH v3 8/9] dt-bindings: xlnx: Add VTC and TPG bindings

[Klymenko, Anatoliy]

Hi Krzysztof,

Thank you for the feedback.

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> Sent: Saturday, March 23, 2024 3:21 AM
> To: Klymenko, Anatoliy <Anatoliy.Klymenko at amd.com>; Laurent Pinchart
> <laurent.pinchart at ideasonboard.com>; Maarten Lankhorst
> <maarten.lankhorst at linux.intel.com>; Maxime Ripard
> <mripard at kernel.org>; Thomas Zimmermann <tzimmermann at suse.de>;
> David Airlie <airlied at gmail.com>; Daniel Vetter <daniel at ffwll.ch>; Simek,
> Michal <michal.simek at amd.com>; Andrzej Hajda
> <andrzej.hajda at intel.com>; Neil Armstrong <neil.armstrong at linaro.org>;
> Robert Foss <rfoss at kernel.org>; Jonas Karlman <jonas at kwiboo.se>; Jernej
> Skrabec <jernej.skrabec at gmail.com>; Rob Herring <robh+dt at kernel.org>;
> Krzysztof Kozlowski <krzysztof.kozlowski+dt at linaro.org>; Conor Dooley
> <conor+dt at kernel.org>; Mauro Carvalho Chehab <mchehab at kernel.org>
> Cc: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>; dri-
> devel at lists.freedesktop.org; linux-arm-kernel at lists.infradead.org; linux-
> kernel at vger.kernel.org; devicetree at vger.kernel.org; linux-
> media at vger.kernel.org
> Subject: Re: [PATCH v3 8/9] dt-bindings: xlnx: Add VTC and TPG bindings
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> On 22/03/2024 20:12, Klymenko, Anatoliy wrote:
> > Hi Krzysztof,
> >
> > Thanks a lot for the review.
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> >> Sent: Thursday, March 21, 2024 10:59 PM
> >> To: Klymenko, Anatoliy <Anatoliy.Klymenko at amd.com>; Laurent Pinchart
> >> <laurent.pinchart at ideasonboard.com>; Maarten Lankhorst
> >> <maarten.lankhorst at linux.intel.com>; Maxime Ripard
> >> <mripard at kernel.org>; Thomas Zimmermann <tzimmermann at suse.de>;
> David
> >> Airlie <airlied at gmail.com>; Daniel Vetter <daniel at ffwll.ch>; Simek,
> >> Michal <michal.simek at amd.com>; Andrzej Hajda
> >> <andrzej.hajda at intel.com>; Neil Armstrong
> >> <neil.armstrong at linaro.org>; Robert Foss <rfoss at kernel.org>; Jonas
> >> Karlman <jonas at kwiboo.se>; Jernej Skrabec
> <jernej.skrabec at gmail.com>;
> >> Rob Herring <robh+dt at kernel.org>; Krzysztof Kozlowski
> >> <krzysztof.kozlowski+dt at linaro.org>; Conor Dooley
> >> <conor+dt at kernel.org>; Mauro Carvalho Chehab <mchehab at kernel.org>
> >> Cc: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>; dri-
> >> devel at lists.freedesktop.org; linux-arm-kernel at lists.infradead.org;
> >> linux- kernel at vger.kernel.org; devicetree at vger.kernel.org; linux-
> >> media at vger.kernel.org
> >> Subject: Re: [PATCH v3 8/9] dt-bindings: xlnx: Add VTC and TPG
> >> bindings
> >>
> >> Caution: This message originated from an External Source. Use proper
> >> caution when opening attachments, clicking links, or responding.
> >>
> >>
> >> On 21/03/2024 21:43, Anatoliy Klymenko wrote:
> >>> diff --git a/include/dt-bindings/media/media-bus-format.h
> >>> b/include/dt-
> >> bindings/media/media-bus-format.h
> >>> new file mode 100644
> >>> index 000000000000..60fc6e11dabc
> >>> --- /dev/null
> >>> +++ b/include/dt-bindings/media/media-bus-format.h
> >>> @@ -0,0 +1,177 @@
> >>> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
> >>> +/*
> >>> + * Media Bus API header
> >>> + *
> >>> + * Copyright (C) 2009, Guennadi Liakhovetski
> >>> +<g.liakhovetski at gmx.de>
> >>> + *
> >>> + * This program is free software; you can redistribute it and/or
> >>> +modify
> >>> + * it under the terms of the GNU General Public License version 2
> >>> +as
> >>> + * published by the Free Software Foundation.
> >>
> >> That's not true. Your SPDX tells something entirely different.
> >>
> >
> > Thank you - I'll see how to fix it.
> >
> >> Anyway, you did not explain why you need to copy anything anywhere.
> >>
> >> Specifically, random hex values *are not bindings*.
> >>
> >
> > The same media bus format values are being used by the reference
> > driver in patch #9. And, as far as I know, we cannot use headers from
> > Linux API headers directly (at least I
> 
> I don't understand what does it mean. You can use in your driver whatever
> headers you wish, I don't care about them.
> 
> 
> noticed the same pattern in ../dt-bindings/sdtv-standarts.h for instance).
> What would be the best approach to reusing the same defines on DT and
> driver sides from your point of view? Symlink maybe?
> >
> 
> Wrap your messages to match mailing list discussion style. There are no
> defines used in DT. If there are, show me them in *THIS* or other
> *upstreamed* (being upstreamed) patchset.
> 

Sorry, I didn't explain properly what I'm trying to achieve. I need to
create a DT node property that represents video signal format, one of
MEDIA_BUS_FMT_* from include/uapi/linux/media-bus-format.h. It would be
nice to reuse the same symbolic values in the device tree. What is the
best approach here? Should I create a separate header in
include/dt-bindings with the same or similar (to avoid multiple
definition errors) defines, or is it better to create a symlink to
media-bus-format.h like include/dt-bindings/linux-event-codes.h?

> Whatever you have out of tree or "DO NOT MERGE" does not matter and
> does not justify anything.
> 
> 
> Best regards,
> Krzysztof

Thank you,
Anatoliy