[PATCH 2/2] dt-bindings: iio: adc: nxp,imx93-adc.yaml: Add calibration properties

[Krzysztof Kozlowski]

On 20/03/2024 11:04, Andrej Picej wrote:
> Document calibration properties and how to set them.

Bindings are before users.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
There is no file extension in prefixes.

> 
> Signed-off-by: Andrej Picej <andrej.picej at norik.com>
> ---
>  .../bindings/iio/adc/nxp,imx93-adc.yaml           | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> index dacc526dc695..64958be62a6a 100644
> --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> @@ -46,6 +46,21 @@ properties:
>    "#io-channel-cells":
>      const: 1
>  
> +  nxp,calib-avg-en:
> +    description:
> +      Enable or disable averaging of calibration time.
> +    enum: [ 0, 1 ]
> +
> +  nxp,calib-nr-samples:
> +    description:
> +      Selects the number of averaging samples to be used during calibration.
> +    enum: [ 16, 32, 128, 512 ]
> +
> +  nxp,calib-t-samples:
> +    description:
> +      Specifies the sample time of calibration conversions.
> +    enum: [ 8, 16, 22, 32 ]

No, use existing, generic properties. Open other bindings for this.

Also, none of these were tested. I am not going to review such untested
code.

It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.

Best regards,
Krzysztof