[PATCH v3 3/4] arm64: add Airoha EN7581 platform
Lorenzo Bianconi
lorenzo at kernel.org
Thu Mar 7 04:14:21 PST 2024
> Il 07/03/24 01:11, Lorenzo Bianconi ha scritto:
> > From: Daniel Danzberger <dd at embedd.com>
> >
> > Introduce the Kconfig entry for the Airoha EN7581 multicore architecture
> > available in the Airoha EN7581 evaluation board.
> >
> > Signed-off-by: Daniel Danzberger <dd at embedd.com>
> > Signed-off-by: Lorenzo Bianconi <lorenzo at kernel.org>
> > ---
> > arch/arm64/Kconfig.platforms | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> > index 24335565bad5..bbe61e233034 100644
> > --- a/arch/arm64/Kconfig.platforms
> > +++ b/arch/arm64/Kconfig.platforms
> > @@ -8,6 +8,19 @@ config ARCH_ACTIONS
> > help
> > This enables support for the Actions Semiconductor S900 SoC family.
> > +config ARCH_AIROHA
> > + bool "Airoha SoC Support"
> > + select ARM_AMBA
>
> ARM_AMBA is selected by ARM64 already, you don't need that one here.
ack, I will fix it in v4.
>
> > + select ARM_GIC
> > + select ARM_GIC_V3
>
> ARM_GIC and ARM_GIC_v3 are also selected by ARM64
ack, I will fix it in v4.
>
> > + select ARM_PSCI
>
> ARM64 selects ARM_PSCI_FW (which should select ARM_PSCI, please verify)
ARM64 selects ARM_PSCI_FW but ARM_PSCI_FW does not seem to select ARM_PSCI.
Am I missing something?
>
> > + select HAVE_ARM_ARCH_TIMER
> > + select COMMON_CLK
>
> ARM64 selects COMMON_CLK already.
ack, I will fix it in v4.
>
> > + help
> > + This enables support for Airoha EN7581 multicore architecture
> > + available on the following SoCs:
> > + - Airoha EN7581 Evaluation Board
>
> You're not going to add one ARCH entry for each MTK Airoha platform, are you?
>
> (if you are, that's wrong)
>
> ....so the help text must be refactored; you could say something like
> "This enables support for the ARM64 based Airoha SoCs"
ack, I will fix it in v4.
>
> ...also, I'm undecided whether MTK should be mentioned or not, here, as those
> SoCs are (...at least the 7581 seems to be) really based on MediaTek router
> chips, in many instances, sharing the same IPs.
Right, EN7581 is similar to mtk router but I do not know if this will be always
true (maybe?? :))
Regards,
Lorenzo
>
>
> Cheers,
> Angelo
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20240307/4104f839/attachment.sig>
More information about the linux-arm-kernel
mailing list