[PATCH net-next v4 05/10] net: ti: icssg-prueth: Add SR1.0-specific description bits

Diogo Ivo diogo.ivo at siemens.com
Wed Mar 6 03:26:36 PST 2024


On 3/5/24 14:41, Russell King (Oracle) wrote:
> On Tue, Mar 05, 2024 at 11:40:25AM +0000, Diogo Ivo wrote:
>> +struct emac_tx_ts_response_sr1 {
>> +	u32 lo_ts;
>> +	u32 hi_ts;
>> +	u32 reserved;
>> +	u32 cookie;
>> +};
> 
> In patch 10, this comes from skb->data, so seems to be a packet. Is the
> data dependent on the host endian, or is it always little endian?

Since prueth_rx_mgm_rsp_thread() in patch 10 calls le32_to_cpu() on the data
it gets from skb->data it seems likely that here the data is also __le32 and
these calls should also be added so that we can use u32 data types. I will
add these calls for next version unless there is some insight here that I am
missing.

Best regards,
Diogo



More information about the linux-arm-kernel mailing list