[PATCH v2 3/5] media: mali-c55: Add Mali-C55 ISP driver

[Dan Scally]

Hi Sakari

On 26/02/2024 11:03, Sakari Ailus wrote:
> < snip>
>> +const struct mali_c55_fmt *mali_c55_cap_fmt_next(const struct mali_c55_fmt *fmt,
>> +						 bool allow_raw, bool unique)
>> +{
>> +	if (!fmt)
>> +		fmt = &mali_c55_fmts[0];
>> +	else
>> +		++fmt;
> fmt++, please.
>
>> +
>> +	for (; fmt < &mali_c55_fmts[ARRAY_SIZE(mali_c55_fmts)]; ++fmt) {
> Ditto.
>
>> +		if (!allow_raw && fmt->is_raw) {
>> +			fmt++;
> Why?


Sorry, I forgot to reply here...I think neither this nor the enumeration filter below is actually 
used - I'll double check and remove them for the v3.


Thanks

Dan

>
>> +			continue;
>> +		}
>> +
>> +		if (unique && !fmt->enumerate) {
>> +			fmt++;
> Here, too.



>
>> +			continue;
>> +		}
>> +
>> +		return fmt;
>> +	}
>> +
>> +	return NULL;
>> +}
>> +