[PATCH v2 3/3] dt-bindings: eeprom: at24: Add at24,mac02e4 and at24,mac02e6
Rob Herring
robh at kernel.org
Mon Jun 24 12:49:13 PDT 2024
On Fri, Jun 21, 2024 at 03:13:40PM +0300, Andrei Simion wrote:
> Update regex check and add pattern to match both EEPROMs.
The subject is wrong as 'at24' is not the vendor.
>
> Signed-off-by: Andrei Simion <andrei.simion at microchip.com>
> ---
> v1 -> v2:
> - change patter into "^atmel,(24(c|cs|mac)[a-z0-9]+|spd)$" to keep simpler
> ---
> Documentation/devicetree/bindings/eeprom/at24.yaml | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
> index 3c36cd0510de..f914ca37ceea 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
> @@ -18,7 +18,7 @@ select:
> properties:
> compatible:
> contains:
> - pattern: "^atmel,(24(c|cs|mac)[0-9]+|spd)$"
> + pattern: "^atmel,(24(c|cs|mac)[a-z0-9]+|spd)$"
> required:
> - compatible
>
> @@ -37,8 +37,8 @@ properties:
> - allOf:
> - minItems: 1
> items:
> - - pattern: "^(atmel|catalyst|microchip|nxp|ramtron|renesas|rohm|st),(24(c|cs|lc|mac)[0-9]+|spd)$"
> - - pattern: "^atmel,(24(c|cs|mac)[0-9]+|spd)$"
> + - pattern: "^(atmel|catalyst|microchip|nxp|ramtron|renesas|rohm|st),(24(c|cs|lc|mac)[a-z0-9]+|spd)$"
> + - pattern: "^atmel,(24(c|cs|mac)[a-z0-9]+|spd)$"
Are these devices available from multiple vendors? If not, I think I'd
add specific compatible strings with the right vendor rather than adding
to this pattern. It's rather loosely defined because that's what was in
use already.
Rob
More information about the linux-arm-kernel
mailing list