[PATCH net-next v8 06/13] net: phy: mediatek: Hook LED helper functions in mtk-ge.c

Daniel Golle daniel at makrotopia.org
Sat Jun 22 14:03:24 PDT 2024


On Sat, Jun 22, 2024 at 07:29:45PM +0200, Andrew Lunn wrote:
> > [...]
> > +	if (index > 1)
> > +		return -EINVAL;
> > +
> 
> It looks like this test could be moved into the common code. It seems
> like all variants have a single LED.

Exactly two LEDs, which is what index > 1 checks for, but yes, it
should be moved to common code.




More information about the linux-arm-kernel mailing list