[PATCH v3] staging: vc04_services: vchiq_arm: Fix initialisation check

[Stefan Wahren]

Am 21.06.24 um 00:10 schrieb Kieran Bingham:
> The vchiq_state used to be obtained through an accessor which would
> validate that the VCHIQ had been initialised correctly with the remote,
> or return a null state.
>
> In commit 42a2f6664e18 ("staging: vc04_services: Move global g_state to
> vchiq_state") the global state was moved to the vchiq_mgnt structures
> stored as a vchiq instance specific context. This conversion removed the
> helpers and instead replaced users of this helper with the assumption
> that the state is always available and the remote connected.
>
> The conversion does ensure that the state is always available, so some
> remaining state null pointer checks that remain are unnecessary, but the
> assumption that the remote is present and initialised is incorrect.
>
> Fix this broken assumption by re-introducing the logic that was lost
> during the conversion.
>
> Fixes: 42a2f6664e18 ("staging: vc04_services: Move global g_state to vchiq_state")
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>

Reviewed-by: Stefan Wahren <wahrenst at gmx.net>

Thanks