[PATCH v2] dt-bindings: i2c: nxp,lpc1788-i2c: convert to dt schema

Krzysztof Kozlowski krzk at kernel.org
Thu Jun 20 03:57:07 PDT 2024


On 20/06/2024 07:40, Kanak Shilledar wrote:
> Convert the NXP I2C controller for LPC2xxx/178x/18xx/43xx
> to newer DT schema. Created DT schema based on the .txt file
> which had `compatible`, `reg`, `interrupts`, `clocks`,
> `#address-cells` and `#size-cells` as required properties.
> 

Thank you for your patch. There is something to discuss/improve.


> +  clocks:
> +    maxItems: 1
> +
> +  clock-frequency:
> +    description: the desired I2C bus clock frequency in Hz
> +    default: 100000
> +
> +  resets:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - "#address-cells"
> +  - "#size-cells"

These should not be required, because you can have an enabled I2C
controller without children in DT.

> +


Best regards,
Krzysztof




More information about the linux-arm-kernel mailing list