[PATCH 1/4] irqchip/armada-370-xp: Do not allow mapping IRQ 0 and 1

Marek Behún kabel at kernel.org
Wed Jun 19 07:11:31 PDT 2024


From: Pali Rohár <pali at kernel.org>

IRQs 0 (IPI) and 1 (MSI) are handled internally by this driver,
generic_handle_domain_irq() is never called for these IRQs.

Disallow mapping these IRQs.

Fixes: 344e873e5657 ("arm: mvebu: Add IPI support via doorbells")
Fixes: 31f614edb726 ("irqchip: armada-370-xp: implement MSI support")
Signed-off-by: Pali Rohár <pali at kernel.org>
[ changed commit message, added Fixes tags ]
Signed-off-by: Marek Behún <kabel at kernel.org>
---
 drivers/irqchip/irq-armada-370-xp.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c
index 4b021a67bdfe..f488c35d9130 100644
--- a/drivers/irqchip/irq-armada-370-xp.c
+++ b/drivers/irqchip/irq-armada-370-xp.c
@@ -566,6 +566,10 @@ static struct irq_chip armada_370_xp_irq_chip = {
 static int armada_370_xp_mpic_irq_map(struct irq_domain *h,
 				      unsigned int virq, irq_hw_number_t hw)
 {
+	/* IRQs 0 and 1 cannot be mapped, they are handled internally */
+	if (hw <= 1)
+		return -EINVAL;
+
 	armada_370_xp_irq_mask(irq_get_irq_data(virq));
 	if (!is_percpu_irq(hw))
 		writel(hw, per_cpu_int_base +
-- 
2.44.2




More information about the linux-arm-kernel mailing list